nswamy commented on a change in pull request #12848: Fix Batch input issue with
Scala Benchmark
URL: https://github.com/apache/incubator-mxnet/pull/12848#discussion_r226004257
##########
File path:
scala-package/examples/src/main/scala/org/apache/mxnetexamples/InferBase.scala
##########
@@ -21,7 +21,7 @@ import org.apache.mxnet._
trait InferBase {
- def loadModel(context: Array[Context]): Any
+ def loadModel(context: Array[Context], batchInference : Boolean): Any
Review comment:
I might have missed when this change was made, I really don't want to add
layers for examples like this. Each example should be standalone and the user
doesn't have go through your example code structure to understand the example
in question. There are 3 APIs in infer package which is not too many to require
further abstraction, please remove this when you work on examples again
@piyushghai
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
