nswamy commented on a change in pull request #12848: Fix Batch input issue with
Scala Benchmark
URL: https://github.com/apache/incubator-mxnet/pull/12848#discussion_r226020193
##########
File path:
scala-package/examples/src/main/scala/org/apache/mxnetexamples/InferBase.scala
##########
@@ -21,7 +21,7 @@ import org.apache.mxnet._
trait InferBase {
- def loadModel(context: Array[Context]): Any
+ def loadModel(context: Array[Context], batchInference : Boolean): Any
Review comment:
The problem I am pointing is all examples are overriding this trait. Adding
metrics is not what is targeted in the examples, its to show the underlying
APIs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
