nswamy commented on a change in pull request #12955: [MXNET-1159]Added unit
tests for making Resource Scope work in Java
URL: https://github.com/apache/incubator-mxnet/pull/12955#discussion_r227881786
##########
File path: scala-package/pom.xml
##########
@@ -190,8 +190,8 @@
<artifactId>maven-compiler-plugin</artifactId>
<version>3.3</version>
<configuration>
- <source>1.6</source>
- <target>1.6</target>
+ <source>1.8</source>
Review comment:
In the same page you linked look at the Note in the same page, its intended
to use Java8 features and throw linkage errors, we haven't used any Java8
features yet but as we keep moving with a lot more Java APIs, we should move to
Java8..I don't think it breaks for Java7 users, although worth checking..
I cannot find what the behavior of this setting is for version 3.3.0 of the
plugin on their doc, may should check their github for [3.3 tag]
(https://github.com/apache/maven-compiler-plugin/tree/maven-compiler-plugin-3.3/)
---
Note: Merely setting the target option does not guarantee that your code
actually runs on a JRE with the specified version. The pitfall is unintended
usage of APIs that only exist in later JREs which would make your code fail at
runtime with a linkage error.
---
After verifying if it indeed breaks 1.7, I suggest to send out a email on
the dev@ seek more opinions and revert if necessary.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
