nswamy commented on a change in pull request #12955: [MXNET-1159]Added unit
tests for making Resource Scope work in Java
URL: https://github.com/apache/incubator-mxnet/pull/12955#discussion_r227911325
##########
File path: scala-package/pom.xml
##########
@@ -190,8 +190,8 @@
<artifactId>maven-compiler-plugin</artifactId>
<version>3.3</version>
<configuration>
- <source>1.6</source>
- <target>1.6</target>
+ <source>1.8</source>
Review comment:
@piyushghai as discussed offline, could you please revert just this change
and bring back only when required - I understand it doesn't impact but to be
sure. You can start a discussion on dev@ about moving to Java8 and dropping
support, many frameworks have moved to support Java8+
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
