eric-haibin-lin commented on a change in pull request #12749: [MXNET-1029]
Feature request: randint operator
URL: https://github.com/apache/incubator-mxnet/pull/12749#discussion_r230529182
##########
File path: src/operator/random/sample_op.h
##########
@@ -78,6 +78,11 @@ struct GenNegBinomialParam {
float alpha;
};
+struct RandIntParam {
+ int low;
Review comment:
What if low is > 4B and dtype is int64? Overflow bug?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
