eric-haibin-lin commented on a change in pull request #12749: [MXNET-1029]
Feature request: randint operator
URL: https://github.com/apache/incubator-mxnet/pull/12749#discussion_r230841583
##########
File path: include/mxnet/random_generator.h
##########
@@ -71,14 +71,23 @@ class RandGenerator<cpu, DType> {
return dist_uniform(*engine_);
}
+ MSHADOW_XINLINE int64_t discrete_uniform(const int64_t lower, const
int64_t upper) {
+ // typedef typename std::conditional<std::is_integral<DType>::value,
Review comment:
Please remove unused code
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services