marcoabreu commented on a change in pull request #13310: [MXNET-703] Update to TensorRT 5, ONNX IR 3. Fix inference bugs. URL: https://github.com/apache/incubator-mxnet/pull/13310#discussion_r236058362
########## File path: src/operator/contrib/nnvm_to_onnx.cc ########## @@ -78,8 +84,13 @@ op::TRTParam ConvertNnvmGraphToOnnx( ModelProto model_proto; // Need to determine IR versions and features to support - model_proto.set_ir_version(static_cast<int64>(2)); + auto opset_proto = model_proto.add_opset_import(); + opset_proto->set_version(static_cast<int64>(8)); Review comment: Magic value? Is there some dynamic approach to retrieve them (e.g. from tensor rt) or can we extract them into some documented constants? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
