marcoabreu commented on a change in pull request #13310: [MXNET-703] Update to
TensorRT 5, ONNX IR 3. Fix inference bugs.
URL: https://github.com/apache/incubator-mxnet/pull/13310#discussion_r236058383
##########
File path: src/operator/contrib/nnvm_to_onnx.cc
##########
@@ -248,8 +259,12 @@ void ConvertPooling(NodeProto* node_proto, const
NodeAttrs& attrs,
AttributeProto* const pads = node_proto->add_attribute();
pads->set_name("pads");
pads->set_type(AttributeProto::INTS);
- for (int kval : pad) {
- pads->add_ints(static_cast<int64>(kval));
+
+ // Convert from MXNet symetric pads to ONNX non-symetric by running through
padding twice.
+ for (int i =0; i < 2; i++) {
Review comment:
This was already done by roshani if I remember it correctly. are we
duplicating code here?
Form my understanding, we would only need onnx->Tensorrt since the mxnet
onnx part should be handled by the existing solution. It feels like we are
developing to parallel approaches here - but I could be mixing things up
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
