TaoLv commented on a change in pull request #13150: support mkl log when dtype
is fp32 or fp64
URL: https://github.com/apache/incubator-mxnet/pull/13150#discussion_r240455015
##########
File path: src/operator/tensor/elemwise_unary_op.h
##########
@@ -348,6 +351,40 @@ class UnaryOp : public OpBase {
LogUnimplementedOp(attrs, ctx, inputs, req, outputs);
}
}
+
+#if MSHADOW_USE_MKL == 1
+static inline void MKL_Log(int size, const float* pIn, float* pOut) {
Review comment:
@eric-haibin-lin Do we have any recommended convention for function/class
name definition in MXNet? Just not feel very comfortable with 4 consecutive
capital letters. :(
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
