TaoLv commented on a change in pull request #13150: support mkl log when dtype
is fp32 or fp64
URL: https://github.com/apache/incubator-mxnet/pull/13150#discussion_r240885471
##########
File path: src/operator/tensor/elemwise_unary_op.h
##########
@@ -348,6 +352,42 @@ class UnaryOp : public OpBase {
LogUnimplementedOp(attrs, ctx, inputs, req, outputs);
}
}
+
+#if MSHADOW_USE_MKL == 1
+ static inline void MKLLog(MKL_INT size, const float* pIn, float* pOut) {
+ vsLn(size, pIn, pOut);
+ }
+
+ static inline void MKLLog(MKL_INT size, const double* pIn, double* pOut) {
+ vdLn(size, pIn, pOut);
+ }
+#endif
+
+ template<typename xpu, typename OP>
+ static void LogCompute(const nnvm::NodeAttrs& attrs,
+ const OpContext& ctx,
+ const std::vector<TBlob>& inputs,
+ const std::vector<OpReqType>& req,
+ const std::vector<TBlob>& outputs) {
+ if (req[0] == kNullOp) return;
+ // if defined MSHADOW_USE_MKL then call mkl log when req is KWriteTo,
type_flag is
+ // mshadow::kFloat32 or mshadow::kFloat64 and data size less than or equal
MKL_INT_MAX
+#if MSHADOW_USE_MKL == 1
+ auto type_flag = inputs[0].type_flag_;
+ const size_t MKL_INT_MAX = (sizeof(MKL_INT) == sizeof(int)) ? INT_MAX :
LLONG_MAX;
+ size_t input_size = inputs[0].Size();
+ if (req[0] == kWriteTo && (type_flag == mshadow::kFloat32
+ || type_flag == mshadow::kFloat64) && input_size <= MKL_INT_MAX) {
+ MSHADOW_SGL_DBL_TYPE_SWITCH(type_flag, DType, {
+ MKLLog(input_size, inputs[0].dptr<DType>(), outputs[0].dptr<DType>());
+ })
Review comment:
need `;` here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
