ZhennanQin commented on a change in pull request #13697: [MKLDNN] Enable signed
int8 support for convolution.
URL: https://github.com/apache/incubator-mxnet/pull/13697#discussion_r244627380
##########
File path: include/mxnet/c_api.h
##########
@@ -1833,10 +1832,12 @@ MXNET_DLL int
MXExecutorGetOptimizedSymbol(ExecutorHandle handle,
/*!
* \brief set a call back to notify the completion of operation
+ * \param monitor_all If true, monitor both input and output, otherwise
monitor output only.
*/
MXNET_DLL int MXExecutorSetMonitorCallback(ExecutorHandle handle,
ExecutorMonitorCallback callback,
- void* callback_handle);
+ void* callback_handle,
+ bool monitor_all);
Review comment:
default value is added in python interface. I'm not sure if we encourage
adding default value for c api. There's no precedent. @KellenSunderland @TaoLv
Do you agree to add default value for c_api?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
