ZhennanQin commented on a change in pull request #13697: [MKLDNN] Enable signed int8 support for convolution. URL: https://github.com/apache/incubator-mxnet/pull/13697#discussion_r244627412
########## File path: src/operator/quantization/mkldnn/mkldnn_quantize_v2-inl.h ########## @@ -0,0 +1,140 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +/*! + * \file mkldnn_quantize_v2-inl.h + * \brief + */ + +#ifndef MXNET_OPERATOR_QUANTIZATION_MKLDNN_MKLDNN_QUANTIZE_V2_INL_H_ +#define MXNET_OPERATOR_QUANTIZATION_MKLDNN_MKLDNN_QUANTIZE_V2_INL_H_ +#if MXNET_USE_MKLDNN == 1 +#include <algorithm> +#include <string> +#include <vector> +#include "../../nn/mkldnn/mkldnn_base-inl.h" +#include "../quantize_v2-inl.h" + +namespace mxnet { +namespace op { + +template <typename SrcType, typename DstType> +static void MKLDNNQuantizeComputeKer(const std::vector<NDArray>& inputs, + const std::vector<NDArray>& outputs, + const QuantizeV2Param& param, + const std::vector<OpReqType>& req) { + using namespace mshadow; + using namespace mxnet_op; + using red::limits::MaxValue; + using red::limits::MinValue; + float real_range = 0.0; + float quantized_range = 0.0; + NDArray in_buffer = inputs[0]; + float data_min = red::limits::MaxValue<float>(); + float data_max = red::limits::MinValue<float>(); + + if (param.min_calib_range.has_value() && param.max_calib_range.has_value()) { + data_min = param.min_calib_range.value(); + data_max = param.max_calib_range.value(); + } else { + // no calib info + in_buffer = inputs[0].Reorder2Default(); + auto in_ptr = in_buffer.data().dptr<float>(); Review comment: good catch. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
