zachgk commented on a change in pull request #13995: [MXNET-1287][WIP] Scala
compiler warnings
URL: https://github.com/apache/incubator-mxnet/pull/13995#discussion_r251557855
##########
File path: scala-package/core/src/main/scala/org/apache/mxnet/IO.scala
##########
@@ -141,28 +141,46 @@ class DataBatch(val data: IndexedSeq[NDArray],
val pad: Int,
// the key for the bucket that should be used for this batch,
// for bucketing io only
- val bucketKey: AnyRef,
+ val bucketKey: AnyRef = null,
// use DataDesc to indicate the order of data/label loading
// (must match the order of input data/label)
- private val providedDataDesc: IndexedSeq[DataDesc],
- private val providedLabelDesc: IndexedSeq[DataDesc]) {
+ private val providedDataDesc: IndexedSeq[DataDesc] = null,
+ private val providedLabelDesc: IndexedSeq[DataDesc] = null) {
// TODO: change the data/label type into IndexedSeq[(NDArray, DataDesc)]
// However, since the data and label can be accessed publicly (no getter and
setter)
// the change on this will break BC
+
+ @deprecated("Use provideDataDesc and provideDataLabel instead", "1.3.0")
Review comment:
provideData and provideLabel were deprecated as part of 1.3. This should
have been deprecated with them (along with a number of other deprecations) so I
think it is better to be accurate to the intent of the deprecation rather than
the chronology of the deprecation
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
