zachgk commented on a change in pull request #13995: [MXNET-1287][WIP] Scala
compiler warnings
URL: https://github.com/apache/incubator-mxnet/pull/13995#discussion_r251561419
##########
File path:
scala-package/core/src/main/scala/org/apache/mxnet/ExecutorManager.scala
##########
@@ -479,15 +480,28 @@ private class DataParallelExecutorGroup private(sym:
Symbol,
trainData: DataIter,
sharedGroup: DataParallelExecutorGroup) {
this(sym, argNames, paramNames, ctx, slices,
- trainData.provideData, trainData.provideLabel, sharedGroup)
+ trainData.provideDataDesc, trainData.provideLabelDesc, sharedGroup)
+ }
+
+ @deprecated("Use provideDataDesc and provideDataLabel instead", "1.3.0")
+ def this(sym: Symbol,
Review comment:
I didn't notice it was private. I'll make sure to remove all private
deprecated code
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
