yuxihu commented on a change in pull request #14397: [WIP] Add exception
handling support for waitall
URL: https://github.com/apache/incubator-mxnet/pull/14397#discussion_r264845472
##########
File path: src/engine/threaded_engine.h
##########
@@ -177,7 +177,11 @@ class ThreadedVar final
static std::atomic<std::size_t> counter;
~ThreadedVar() { LOG(INFO) << __func__ << " " << --counter; }
#endif // ENGINE_DEBUG
- /*! \brief exception_ptr associated with the ThreadedVar */
+ /*!
+ * \brief exception_ptr associated with the ThreadedOpr
+ * cannot modify state of exception object since dereferencing
+ * exception_ptr is undefined behavior. Using shared_ptr to hold
Review comment:
Look likes
[exception_ptr](https://en.cppreference.com/w/cpp/error/exception_ptr) is
already a shared-ownership smart pointer. Would that be sufficient for our use
cases, instead of wrapping it with shared_ptr?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
