yuxihu commented on a change in pull request #14397: [WIP] Add exception
handling support for waitall
URL: https://github.com/apache/incubator-mxnet/pull/14397#discussion_r264846358
##########
File path: src/engine/threaded_engine.h
##########
@@ -432,6 +440,9 @@ class ThreadedEngine : public Engine {
};
/*! thread local store for bulk */
typedef dmlc::ThreadLocalStore<BulkStatus> BulkStatusStore;
+ /*! shared_ptr to exception_ptr, used for exception handling */
+ typedef std::shared_ptr<std::exception_ptr> ExceptionRef;
Review comment:
can we also use ExceptionRef in other locations where we use
std::shared_ptr<std::exception_ptr>？
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
