vishaalkapoor commented on a change in pull request #14530: Added repeats for
github status updates
URL: https://github.com/apache/incubator-mxnet/pull/14530#discussion_r269686803
##########
File path: ci/Jenkinsfile_utils.groovy
##########
@@ -186,18 +186,27 @@ def update_github_commit_status(state, message) {
context = get_github_context()
echo "context=${context}"
- step([
- $class: 'GitHubCommitStatusSetter',
- reposSource: [$class: "ManuallyEnteredRepositorySource", url: repoUrl],
- contextSource: [$class: "ManuallyEnteredCommitContextSource", context:
context],
- commitShaSource: [$class: "ManuallyEnteredShaSource", sha: commitSha],
- statusBackrefSource: [$class: "ManuallyEnteredBackrefSource", backref:
"${env.RUN_DISPLAY_URL}"],
- errorHandlers: [[$class: 'ShallowAnyErrorHandler']],
- statusResultSource: [
- $class: 'ConditionalStatusResultSource',
- results: [[$class: "AnyBuildResult", message: message, state: state]]
- ]
- ])
+ // a few attempts need to be made:
https://github.com/apache/incubator-mxnet/issues/11654
+ for (int attempt = 1; attempt < 4; attempt++) {
+ echo "Sending GitHub status attempt ${attempt}..."
+
+ step([
Review comment:
I don't understand few points here
- (why) will this step be repeated if it's successful? is there a way to see
if the step succeeded and not iterate?
- is the operation idempotent (in the event you cannot determine if the step
succeeded and are forced to do the step several times)?
- What kind of outages is the backoff strategy aiming to mitigate and what
is the duration and cause of those outages? Is the backoff of 1 second x 3
empirically effective? Have you considered different strategies? note this
isn't a high throughput situation so i wouldn't recommend anything like
randomized exponential backoff, but I was curious about exponential backoff.
- is there a more robust way to handle this planned?
Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
