vishaalkapoor commented on a change in pull request #14530: Added repeats for
github status updates
URL: https://github.com/apache/incubator-mxnet/pull/14530#discussion_r270075529
##########
File path: ci/Jenkinsfile_utils.groovy
##########
@@ -186,18 +186,27 @@ def update_github_commit_status(state, message) {
context = get_github_context()
echo "context=${context}"
- step([
- $class: 'GitHubCommitStatusSetter',
- reposSource: [$class: "ManuallyEnteredRepositorySource", url: repoUrl],
- contextSource: [$class: "ManuallyEnteredCommitContextSource", context:
context],
- commitShaSource: [$class: "ManuallyEnteredShaSource", sha: commitSha],
- statusBackrefSource: [$class: "ManuallyEnteredBackrefSource", backref:
"${env.RUN_DISPLAY_URL}"],
- errorHandlers: [[$class: 'ShallowAnyErrorHandler']],
- statusResultSource: [
- $class: 'ConditionalStatusResultSource',
- results: [[$class: "AnyBuildResult", message: message, state: state]]
- ]
- ])
+ // a few attempts need to be made:
https://github.com/apache/incubator-mxnet/issues/11654
+ for (int attempt = 1; attempt < 4; attempt++) {
+ echo "Sending GitHub status attempt ${attempt}..."
+
+ step([
Review comment:
Apologies for missing the first point which was addressed in the comments,
but you didn't adderss backoff or idempotence :) If the back-off strategy isn't
right, you may see the issue reappear with some low frequency.
I'm good with committing because it will temporarily fix the issue at least
(LGTM)
A suggestion if it's not in the comments already :) Can you repro with a
minimal scenario and figure out some probabilities (to justify 4 back-offs and
a 1 second delay)?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
