TaoLv commented on a change in pull request #14604: [MKLDNN]Add quantized relu
URL: https://github.com/apache/incubator-mxnet/pull/14604#discussion_r273788512
 
 

 ##########
 File path: tests/python/quantization/test_quantization.py
 ##########
 @@ -414,6 +414,57 @@ def check_quantized_flatten(shape, qdtype):
         check_quantized_flatten((10, 15, 18), qdtype)
         check_quantized_flatten((3, 4, 23, 23), qdtype)
 
+@with_seed()
+def test_quantized_act():
 
 Review comment:
   Fine. I'm personally okay about there is no non-relu cases in UT. But do you 
mind running one on your machine and paste the error log here? I just want to 
make sure that the error happens at a appropriate place and the message is 
accurate.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to