TaoLv commented on a change in pull request #14604: [MKLDNN]Add quantized relu
URL: https://github.com/apache/incubator-mxnet/pull/14604#discussion_r274897893
##########
File path: src/operator/nn/mkldnn/mkldnn_act.cc
##########
@@ -74,75 +74,51 @@ static inline mkldnn::algorithm GetMKLDNNActAlgo(const
ActivationParam& param) {
}
}
-typedef std::shared_ptr<mkldnn::eltwise_forward::primitive_desc>
mkldnn_act_pdesc_ptr;
-
-static mkldnn::eltwise_forward::primitive_desc GetActFwdDescImpl(
+mkldnn::eltwise_forward::primitive_desc GetActFwdDescImpl(
const ActivationParam& param, bool is_train,
const mkldnn::memory &input_mem, int dtype) {
mkldnn::memory::primitive_desc data_mpd = input_mem.get_primitive_desc();
mkldnn::memory::desc data_md = data_mpd.desc();
auto cpu_engine = data_mpd.get_engine();
auto alg = GetMKLDNNActAlgo(param);
- MSHADOW_REAL_TYPE_SWITCH(dtype, DType, {
- DType alpha = 0;
- mkldnn::eltwise_forward::desc desc = is_train
- ? mkldnn::eltwise_forward::desc(mkldnn::prop_kind::forward_training,
- alg, data_md, alpha)
- : mkldnn::eltwise_forward::desc(mkldnn::prop_kind::forward_scoring,
- alg, data_md, alpha);
- return mkldnn::eltwise_forward::primitive_desc(desc, cpu_engine);
- });
- LOG(FATAL) << "Unsupported data type for MKLDNN activation";
- mkldnn::eltwise_forward::desc desc = mkldnn::eltwise_forward::desc(
- mkldnn::prop_kind::forward_training, alg, data_md, 0.0);
+
+ mkldnn::eltwise_forward::desc desc = is_train
+ ? mkldnn::eltwise_forward::desc(mkldnn::prop_kind::forward_training,
+ alg, data_md, 0.0f)
+ : mkldnn::eltwise_forward::desc(mkldnn::prop_kind::forward_scoring,
+ alg, data_md, 0.0f);
Review comment:
Looks strange to me here. Suggest:
```cpp
auto prop = is_train ? mkldnn::prop_kind::forward_training :
mkldnn::prop_kind::forward_scoring;
auto desc = mkldnn::eltwise_forward::desc(prop, alg, data_md, 0.0f);
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
