eric-haibin-lin commented on a change in pull request #14568: NAG Optimizer 
with multi-precision support
URL: https://github.com/apache/incubator-mxnet/pull/14568#discussion_r275141015
 
 

 ##########
 File path: src/operator/optimizer_op.cc
 ##########
 @@ -705,6 +707,98 @@ only the row slices whose indices appear in grad.indices 
are updated (for w, m a
 .add_arguments(AdamParam::__FIELDS__());
 
 
+NNVM_REGISTER_OP(nag_update)
+MXNET_ADD_SPARSE_OP_ALIAS(nag_update)
 
 Review comment:
   remove MXNET_ADD_SPARSE_OP_ALIAS

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to