larroy commented on issue #14631: Fix build_ccache_wrappers: URL: https://github.com/apache/incubator-mxnet/pull/14631#issuecomment-484743242 As you can see in your patch, ccache is disabled from one build because there's a problem. My PR fixes that problems, makes the function work without needing root privileges and more. Can you provide a reason why are you blocking this PR? This PR doesn't affect the hit rate of ccache but increase it, based on what are you making these claims? It's also not idempotent, the second time you call it it will fail, preventing all the build functions to be called multiple times which is essential if you are making changes or want to rebuild. ``` jenkins_slave@9c9d63f274c2:/work/mxnet$ /work/runtime_functions.sh build_ubuntu_cpu + NOSE_COVERAGE_ARGUMENTS='--with-coverage --cover-inclusive --cover-xml --cover-branches --cover-package=mxnet' + NOSE_TIMER_ARGUMENTS='--with-timer --timer-ok 1 --timer-warning 15 --timer-filter warning,error' + CI_CUDA_COMPUTE_CAPABILITIES='-gencode=arch=compute_52,code=sm_52 -gencode=arch=compute_70,code=sm_70' + CI_CMAKE_CUDA_ARCH_BIN=52,70 + set +x + export CC=gcc + CC=gcc + export CXX=g++ + CXX=g++ + build_ccache_wrappers + set -ex + '[' -z x ']' + '[' -z x ']' + mkdir /tmp/ccache-redirects mkdir: cannot create directory '/tmp/ccache-redirects': File exists ```
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
