reminisce commented on a change in pull request #14733: Enable zero-copy from
numpy to MXNet NDArray
URL: https://github.com/apache/incubator-mxnet/pull/14733#discussion_r277515312
##########
File path: tests/python/unittest/test_ndarray.py
##########
@@ -1653,6 +1653,14 @@ def test_ndarray_nan_comparison():
for i in (np.isnan(data1_grad))[1][0].flatten():
assert i == True
+
+def test_zero_from_numpy():
Review comment:
Can you add more test cases including
1. scalar tensors.
2. zero-size tensors.
3. `zero_copy=False`.
4. Perturbing the elements of numpy ndarray will equivalently affect mxnet
NDArray, and vice versa.
5. Deleting either one of them should not obliterate the content of the
other one when `zero_copy=True` and `False`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
