anirudhacharya commented on a change in pull request #14568: NAG Optimizer with multi-precision support URL: https://github.com/apache/incubator-mxnet/pull/14568#discussion_r279113077
########## File path: src/operator/optimizer_op.cc ########## @@ -705,6 +707,94 @@ only the row slices whose indices appear in grad.indices are updated (for w, m a .add_arguments(AdamParam::__FIELDS__()); +NNVM_REGISTER_OP(nag_update) Review comment: yes, and `mp_nag_update` is same as `mp_sgd_update` because nag without momentum and sgd without momentum is similar. you want me to reuse that? i thought it might be weird to use them here without renaming them. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
