stephenrawls commented on a change in pull request #14208: Add support for fast variable-length LSTM URL: https://github.com/apache/incubator-mxnet/pull/14208#discussion_r281424953
########## File path: src/operator/rnn-inl.h ########## @@ -28,6 +28,7 @@ #define MXNET_USE_CUDNN_RNN MXNET_USE_CUDNN == 1 && CUDNN_MAJOR >= 5 #define USE_CUDNN_LSTM_PROJ MXNET_USE_CUDNN == 1 && CUDNN_VERSION >= 7200 +#define USE_VAR_SEQ_LENGTH MXNET_USE_CUDNN == 1 && CUDNN_VERSION >= 7200 Review comment: Fair enough. At first I added it since I was putting things that had nothing to do with LSTM_PROJ under this #ifdef guard. Maybe I'll just rename it to something that makes sense for both uses. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
