reminisce commented on a change in pull request #13143: [MXNET-1206] Support
NDArray indexing with None and Ellipsis
URL: https://github.com/apache/incubator-mxnet/pull/13143#discussion_r285365793
##########
File path: python/mxnet/ndarray/ndarray.py
##########
@@ -387,19 +388,15 @@ def __setstate__(self, state):
else:
self.handle = None
- # pylint: disable=line-too-long
def __setitem__(self, key, value):
"""x.__setitem__(i, y) <=> x[i]=y
- Sets value to self[key]. This functions supports advanced indexing
defined in the following reference with
- some restrictions.
-
-
https://docs.scipy.org/doc/numpy-1.13.0/reference/arrays.indexing.html#combining-advanced-and-basic-indexing
+ Sets ``self[key]`` to ``value``.
- - If key is a list type, only a list of integers is supported, e.g.
key=[1, 2] is supported,
Review comment:
We only supported list of integers when the `key` is a list because we find
the behavior of nested lists are confusing. For example, `x[[1], [2]]` is
equivalent to `x[[[1], [2]]]`. Has this implementation enable indexing with key
as a nested list? If so, could you explain and document the behavior consistent
with numpy?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
