reminisce commented on a change in pull request #13143: [MXNET-1206] Support
NDArray indexing with None and Ellipsis
URL: https://github.com/apache/incubator-mxnet/pull/13143#discussion_r285365479
##########
File path: tests/python/unittest/test_ndarray.py
##########
@@ -1292,7 +1358,9 @@ def test_setitem_autograd(np_array, index):
try:
with mx.autograd.record():
x[index] = y
- assert False # should not reach here
+ # TODO: figure out why `None` doesn't raise
Review comment:
I guess it's because this case is equivalent to `y.copyto(x)`, where `x` is
only passed into the autograd recorder as a pure output, while in other cases,
`x` is passed as both an input and an output tensor. Therefore, it's fine to
skip this case.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
