arcadiaphy commented on a change in pull request #15007: Add matrix determinant
operator in linalg
URL: https://github.com/apache/incubator-mxnet/pull/15007#discussion_r287304594
##########
File path: src/operator/tensor/la_op.cc
##########
@@ -939,5 +939,153 @@ NNVM_REGISTER_OP(_backward_linalg_inverse)
.set_attr<nnvm::TIsBackward>("TIsBackward", true)
.set_attr<FCompute>("FCompute<cpu>", LaOpBackward<cpu, 2, 2, 2, 1,
inverse_backward>);
+NNVM_REGISTER_OP(_linalg_det)
Review comment:
Good point. If we only want to keep only one method, then the `slogdet` is
the best choice.
Since the community is now working on providing numpy experience in mxnet,
how about we follow the numpy.linalg package, and keep `det` and `slogdet`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
