arcadiaphy commented on a change in pull request #15007: Add matrix determinant
operator in linalg
URL: https://github.com/apache/incubator-mxnet/pull/15007#discussion_r287316688
##########
File path: src/operator/tensor/la_op-inl.h
##########
@@ -825,6 +901,100 @@ struct inverse_backward {
}
};
+// Here we set grad to zero if det = 0 as a temporary method
Review comment:
I'm not very sure how to handle det = 0 case. If it's ok to use zero here,
I'll change the comment and add a note in operator docs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
