apeforest commented on a change in pull request #15170: [MXNET-1413] Adding
Large Tensor support for sort operators
URL: https://github.com/apache/incubator-mxnet/pull/15170#discussion_r291415286
##########
File path: src/operator/tensor/ordering_op-inl.h
##########
@@ -454,8 +457,8 @@ void TopKImpl(const RunContext &ctx,
workspace_curr_ptr += temp_size;
}
- mxnet_op::Kernel<range_fwd, xpu>::Launch(s, batch_size * element_num, 1, 0,
1,
- kWriteTo, indices.dptr_);
+ mxnet_op::Kernel<range_fwd, xpu>::Launch(s, batch_size * element_num, 1,
static_cast<index_t>(0),
+ static_cast<index_t>(1), kWriteTo,
indices.dptr_);
Review comment:
Maybe just using data initializer:
```suggestion
index_t{0}, index_t{1}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
