apeforest commented on a change in pull request #15170: [MXNET-1413] Adding Large Tensor support for sort operators URL: https://github.com/apache/incubator-mxnet/pull/15170#discussion_r295975892
########## File path: src/operator/tensor/ordering_op-inl.h ########## @@ -785,8 +813,12 @@ inline bool SortType(const nnvm::NodeAttrs& attrs, size_t out_size = out_attrs->size(); CHECK_EQ(in_size, 1); CHECK_EQ(out_size, 2); +#if MXNET_USE_INT64_TENSOR_SIZE == 1 + CHECK(type_assign(&(*out_attrs)[1], mshadow::kInt64)) +#else CHECK(type_assign(&(*out_attrs)[1], mshadow::kInt32)) - << "Failed to set the type of ret_indices to int32."; +#endif + << "Failed to set the type of ret_indices to int32."; Review comment: I think this message should be different when `MSHADOW_USE_INT64_TENSOR_SIZE` is on. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
