sandeep-krishnamurthy commented on a change in pull request #15132: Profiler
API Enhancements
URL: https://github.com/apache/incubator-mxnet/pull/15132#discussion_r291419712
##########
File path: src/profiler/aggregate_stats.cc
##########
@@ -28,100 +28,210 @@
#include <fstream>
#include <thread>
#include <iomanip>
+#include <queue>
+#include <utility>
#include "./profiler.h"
namespace mxnet {
namespace profiler {
+using pi = std::pair<double, std::string>;
+
template<typename DType>
inline float MicroToMilli(const DType micro) {
return static_cast<float>(static_cast<double>(micro) / 1000);
}
+template<typename DType>
+inline float ByteToKilobyte(const DType micro) {
+ return static_cast<float>(static_cast<double>(micro) / 100);
Review comment:
1000?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
