sandeep-krishnamurthy commented on a change in pull request #15132: Profiler
API Enhancements
URL: https://github.com/apache/incubator-mxnet/pull/15132#discussion_r293511601
##########
File path: src/profiler/aggregate_stats.h
##########
@@ -57,16 +57,31 @@ class AggregateStats {
*/
void OnProfileStat(const ProfileStat& stat);
/*!
- * \brief Print profliing statistics to console
+ * \brief Print profliing statistics to console in a tabular fasion
* \param clear Delete all of the current statistics after printing
*/
- void Dump(std::ostream& os, bool clear);
+ void DumpTable(std::ostream& os, int sort_by, int ascending);
+ /*!
+ * \brief Print profliing statistics to console in json
+ */
+ void DumpJson(std::ostream& os, int sort_by, int ascending);
+ /*!
+ * \brief Delete all of the current statistics
+ */
+ void clear();
private:
/*! \brief Should rarely collide, so most locks should occur only in
user-space (futex) */
std::mutex m_;
/* !\brief Stat type -> State name -> Stats */
std::map<std::string, std::unordered_map<std::string, StatData>> stats_;
+ // /* !\brief Sort by which stat */
Review comment:
remove commented code
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
