larroy commented on a change in pull request #14779: [WIP] Fully connected,
higher order grad
URL: https://github.com/apache/incubator-mxnet/pull/14779#discussion_r305545140
##########
File path: src/operator/nn/fully_connected-inl.h
##########
@@ -91,21 +140,14 @@ void FCForward(const OpContext &ctx, const
FullyConnectedParam ¶m,
CHECK_EQ(s->blas_handle_ownership_, Stream<xpu>::OwnHandle)
<< "Must init CuBLAS handle in stream";
#endif // __CUDACC__
- const mxnet::TShape& ishape = in_data[fullc::kData].shape_;
Review comment:
It's related I created a function that does that same thing because it's
going to use in the two places. It's code duplication. If one factors out some
code, it should be then factored out in other places which uses it. I could
make a separate PR if it really bothers you.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
