larroy commented on a change in pull request #14779: [WIP] Fully connected,
higher order grad
URL: https://github.com/apache/incubator-mxnet/pull/14779#discussion_r305546292
##########
File path: src/operator/nn/fully_connected.cc
##########
@@ -210,11 +222,11 @@ inline static bool FCStorageType(const nnvm::NodeAttrs&
attrs,
return dispatched;
}
-inline static bool BackwardFCStorageType(const nnvm::NodeAttrs& attrs,
- const int dev_mask,
- DispatchMode* dispatch_mode,
- std::vector<int> *in_attrs,
- std::vector<int> *out_attrs) {
+static bool BackwardFCStorageType(const nnvm::NodeAttrs& attrs,
Review comment:
I have explained this before countless times. This is just code bloat, the
function has several calls and a loop inside, inline does nothing good here.
The compiler knows when to inline.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
