apeforest commented on a change in pull request #15593: Large Index Support for
Slice
URL: https://github.com/apache/incubator-mxnet/pull/15593#discussion_r306638983
##########
File path: include/mxnet/c_predict_api.h
##########
@@ -42,7 +42,9 @@ extern "C" {
#endif
/*! \brief manually define unsigned int */
-typedef unsigned int mx_uint;
+typedef uint32_t mx_uint;
Review comment:
still feel this typedef is redundant and decrease readability. The fact the
same data types are defined in two different headers might cause include error.
But it's okay to change this in a different PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
