apeforest commented on a change in pull request #15593: Large Index Support for Slice URL: https://github.com/apache/incubator-mxnet/pull/15593#discussion_r306929066
########## File path: tests/nightly/test_large_array.py ########## @@ -157,8 +157,8 @@ def test_take(): def test_slice(): - a = nd.ones(shape=(LARGE_X, SMALL_Y)) - res = nd.slice(a, begin=(LARGE_X-1000, 1), end=(LARGE_X, SMALL_Y)) + a = nd.ones(shape=(2, LARGE_SIZE)) Review comment: Why do we need to test 2 and update the LARGE_SIZE? I would suggest we keep this test file as it is and create a separate test file test_large_vector.py to test large single dimension input. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
