apeforest commented on a change in pull request #15728: Large Index
Support:Part 1
URL: https://github.com/apache/incubator-mxnet/pull/15728#discussion_r310237185
##########
File path: src/c_api/c_api_symbolic.cc
##########
@@ -708,6 +787,31 @@ int MXSymbolInferShapePartialEx(SymbolHandle sym,
&succ);
}
+int MXSymbolInferShapePartialExInt64(SymbolHandle sym,
+ mx_uint num_args,
+ const char** keys,
+ const int64_t *arg_ind_ptr,
+ const int64_t *arg_shape_data,
+ size_t *in_shape_size,
+ const int **in_shape_ndim,
+ const int64_t ***in_shape_data,
+ size_t *out_shape_size,
+ const int **out_shape_ndim,
+ const int64_t ***out_shape_data,
+ size_t *aux_shape_size,
+ const int **aux_shape_ndim,
+ const int64_t ***aux_shape_data,
+ int *complete) {
+ int succ;
Review comment:
initilize the value of succ and better to rename it `success`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
