apeforest commented on a change in pull request #15728: Large Index
Support:Part 1
URL: https://github.com/apache/incubator-mxnet/pull/15728#discussion_r310304666
##########
File path: python/mxnet/ndarray/ndarray.py
##########
@@ -1947,9 +1949,14 @@ def shape(self):
(2L, 3L, 4L)
"""
ndim = mx_int()
- pdata = ctypes.POINTER(mx_int)()
- check_call(_LIB.MXNDArrayGetShapeEx(
- self.handle, ctypes.byref(ndim), ctypes.byref(pdata)))
+ if Features().is_enabled('INT64_TENSOR_SIZE') and sys.version_info[0]
> 2:
Review comment:
I think calling the Feature().is_enabled() may take extra time here
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
