larroy commented on a change in pull request #15581: Numpy-compatible Infra URL: https://github.com/apache/incubator-mxnet/pull/15581#discussion_r310340506
########## File path: include/mxnet/tuple.h ########## @@ -272,6 +272,14 @@ class Tuple { is.get(); if (ch == '(' || ch == '[') break; if (!isspace(ch)) { + if (ch == 'N') { Review comment: can't this be on the same line using short circuit? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services