larroy commented on a change in pull request #15581: Numpy-compatible Infra
URL: https://github.com/apache/incubator-mxnet/pull/15581#discussion_r310341343
##########
File path: src/operator/tensor/broadcast_reduce_op.h
##########
@@ -977,24 +1037,40 @@ inline void BroadcastComputeImpl(const nnvm::NodeAttrs&
attrs,
const mxnet::TShape& small) {
using namespace mshadow;
using namespace mshadow::expr;
+ using namespace mxnet_op;
mxnet::TShape src_shape, dst_shape;
BroadcastReduceShapeCompact(outputs[0].shape_, small, &dst_shape,
&src_shape);
Stream<xpu> *s = ctx.get_stream<xpu>();
Review comment:
can we name the variable "stream" instead of single letter?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
