zixuanweeei commented on issue #15741: MKL-DNN LBR-GRU Inference Integration (FP32 LBR-GRU) URL: https://github.com/apache/incubator-mxnet/pull/15741#issuecomment-518007226 > Do all comments in the original thread are resolved? Yes, all comments are resolved. @TaoLv Could you check on this PR for LBR-GRU integration again? Specifically, the type of input params of `GetMKLDNNRNNCacheMemorySize` is changed to `size_t`, https://github.com/apache/incubator-mxnet/blob/fd1e21443eaad240210079b0fbebd5c062f06663/src/operator/nn/mkldnn/mkldnn_rnn_impl.h#L138-L144 and using reference or pointer to access a `memory`. https://github.com/apache/incubator-mxnet/blob/fd1e21443eaad240210079b0fbebd5c062f06663/src/operator/nn/mkldnn/mkldnn_rnn_impl.h#L304 https://github.com/apache/incubator-mxnet/blob/fd1e21443eaad240210079b0fbebd5c062f06663/src/operator/nn/mkldnn/mkldnn_rnn_impl.h#L472 https://github.com/apache/incubator-mxnet/blob/fd1e21443eaad240210079b0fbebd5c062f06663/src/operator/nn/mkldnn/mkldnn_rnn_impl.h#L490-L491
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
