zixuanweeei commented on issue #15741: MKL-DNN LBR-GRU Inference Integration 
(FP32 LBR-GRU)
URL: https://github.com/apache/incubator-mxnet/pull/15741#issuecomment-520121185
 
 
   Not sure why the outputs of fused cell are all zeors. We made `mem_space_` 
for MKL-DNN, which is allocated from `Storage` in #15621 , be allocated from 
tempspace resource in this PR.
   
https://github.com/apache/incubator-mxnet/blob/b2aaf966eb0700dc9923f45253f1332e88eced4a/src/operator/rnn.cc#L272-L275
   
   Does this matter?
   
   And for the another one, I think we should reproduce the failures at first. 
I have looked through the Forward interface trying to locate the problem and 
found no joint use of temp space. @DickJC123 Would you mind checking it again? 
If the failures don't appear again, I think we can just move further since 
MKL-DNN is going to be update to another new version. And I think the stateful 
`FStatefulComputeEx` interface of RNN needs some refactoring after update. 
What's your opinions? @pengzhao-intel @TaoLv @ciyongch  
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to