haojin2 commented on a change in pull request #15699: Numpy take operator
implementation & bug fix in ndarray.take
URL: https://github.com/apache/incubator-mxnet/pull/15699#discussion_r310808895
##########
File path: src/operator/tensor/indexing_op.h
##########
@@ -341,6 +341,53 @@ struct Take {
}
};
+template<bool clip = true>
Review comment:
Why are you moving device-specific kernel to `.h` ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
