haojin2 commented on a change in pull request #15699: Numpy take operator implementation & bug fix in ndarray.take URL: https://github.com/apache/incubator-mxnet/pull/15699#discussion_r310811111
########## File path: src/operator/numpy/indexing_op.cc ########## @@ -0,0 +1,158 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +/*! + * Copyright (c) 2019 by Contributors + * \file indexing_op.cc + * \brief CPU implementation of numpy indexing operator +*/ + +#include "./indexing_op.h" + +namespace mxnet { +namespace op { + +template<> +void NumpyTakeOpForward<cpu>(const nnvm::NodeAttrs& attrs, + const OpContext& ctx, Review comment: Align the arguments: ```c++ template<> void NumpyTakeOpForward<cpu>(const nnvm::NodeAttrs& attrs, const OpContext& ctx, const std::vector<TBlob>& inputs, const std::vector<OpReqType>& req, const std::vector<TBlob>& outputs) { ``` Same for all functions. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
