KellenSunderland commented on a change in pull request #15751: Fix the bug of
`MXEnginePushAsyncND` and `MXEnginePushSyncND`
URL: https://github.com/apache/incubator-mxnet/pull/15751#discussion_r311297870
##########
File path: src/c_api/c_api.cc
##########
@@ -1564,18 +1564,18 @@ int MXEnginePushAsyncND(EngineAsyncFunc async_func,
void* func_param,
}
int MXEnginePushSyncND(EngineSyncFunc sync_func, void* func_param,
- EngineFuncParamDeleter deleter, ContextHandle ctx_handle,
- NDArrayHandle const_nds_handle, int num_const_nds,
- NDArrayHandle mutable_nds_handle, int num_mutable_nds,
- EngineFnPropertyHandle prop_handle, int priority,
- const char* opr_name) {
- API_BEGIN();
- NDArray* const_nds = static_cast<NDArray*>(const_nds_handle);
- NDArray* mutable_nds = static_cast<NDArray*>(mutable_nds_handle);
+ EngineFuncParamDeleter deleter, ContextHandle
ctx_handle,
+ NDArrayHandle* const_nds_handle, int num_const_nds,
Review comment:
This may count as a breaking change of the public API after a release. If
the intent is to have many NDArrays passed to this function would one option be
to concat them together and submit them as one large NDArray? Would you be
able to give some detail about what pieces integrate with this API? Is it
possible we can make a change on that code?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
