KellenSunderland commented on a change in pull request #15751: Fix the bug of
`MXEnginePushAsyncND` and `MXEnginePushSyncND`
URL: https://github.com/apache/incubator-mxnet/pull/15751#discussion_r311299571
##########
File path: tests/cpp/engine/threaded_engine_test.cc
##########
@@ -258,47 +258,50 @@ TEST(Engine, PushFunc) {
TEST(Engine, PushFuncND) {
auto ctx = mxnet::Context{};
mxnet::NDArray nd(ctx);
+ std::vector<mxnet::NDArray*> nds;
+ nds.push_back(&nd);
+ void** pnds = reinterpret_cast<void**>(nds.data());
Review comment:
We might want some tests for cases with more than 1 NDArray present in the
argument call.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
