ZhennanQin commented on a change in pull request #15664: add int8 bn mkldnn
implementation and test
URL: https://github.com/apache/incubator-mxnet/pull/15664#discussion_r311338747
##########
File path: src/operator/nn/batch_norm-inl.h
##########
@@ -81,19 +93,35 @@ struct BatchNormParam : public
dmlc::Parameter<BatchNormParam> {
DMLC_DECLARE_FIELD(output_mean_var).set_default(false)
.describe("Output the mean and inverse std ");
DMLC_DECLARE_FIELD(axis).set_default(mxnet::op::batchnorm::DEFAULT_AXIS)
- .describe("Specify which shape axis the channel is specified");
+ .describe("Specify which shape axis the channel is specified");
DMLC_DECLARE_FIELD(cudnn_off).set_default(false)
- .describe("Do not select CUDNN operator, if available");
+ .describe("Do not select CUDNN operator, if available");
+ DMLC_DECLARE_FIELD(min_calib_range)
+ .set_default(dmlc::optional<float>())
+ .describe("The minimum scalar value in the form of float32 obtained "
+ "through calibration. If present, it will be used to by "
+ "quantized batch norm op to calculate primitive scale");
+ DMLC_DECLARE_FIELD(max_calib_range)
+ .set_default(dmlc::optional<float>())
+ .describe("The maximum scalar value in the form of float32 obtained "
+ "through calibration. If present, it will be used to by "
+ "quantized batch norm op to calculate primitive scale");
}
- bool operator==(const BatchNormParam& other) const {
- return this->eps == other.eps &&
- this->momentum == other.momentum &&
- this->fix_gamma == other.fix_gamma &&
- this->use_global_stats == other.use_global_stats &&
- this->output_mean_var == other.output_mean_var &&
- this->axis == other.axis &&
- this->cudnn_off == other.cudnn_off;
+ bool operator==(const BatchNormParam &other) const {
+ bool flag = this->eps == other.eps && this->momentum == other.momentum &&
+ this->fix_gamma == other.fix_gamma &&
+ this->use_global_stats == other.use_global_stats &&
+ this->output_mean_var == other.output_mean_var && this->axis
== other.axis &&
+ this->cudnn_off == other.cudnn_off &&
+ this->min_calib_range.has_value() ==
other.min_calib_range.has_value() &&
+ this->max_calib_range.has_value() ==
other.max_calib_range.has_value();
+ if (this->min_calib_range.has_value() && other.min_calib_range.has_value()
&&
Review comment:
Not enough. Please check min and max separately, and consider the condition
that only one side has value.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
