[GitHub] [incubator-mxnet] ZhennanQin commented on a change in pull request #15664: add int8 bn mkldnn implementation and test

Tue, 06 Aug 2019 18:41:28 -0700 

ZhennanQin commented on a change in pull request #15664: add int8 bn mkldnn 
implementation and test
URL: https://github.com/apache/incubator-mxnet/pull/15664#discussion_r311338901
 
 

 ##########
 File path: src/operator/nn/batch_norm.cc
 ##########
 @@ -396,7 +396,7 @@ void BatchNormComputeExCPU(const nnvm::NodeAttrs &attrs,
   CHECK_EQ(inputs.size(), 5U);
   const BatchNormParam &param = nnvm::get<BatchNormParam>(attrs.parsed);
   // MKLDNN batchnorm only works well on the special MKLDNN layout.
-  if (SupportMKLDNNBN(inputs[0], param) && inputs[0].IsMKLDNNData()) {
+  if (SupportMKLDNNBN(inputs[0], param) /*&& inputs[0].IsMKLDNNData() */) {
 
 Review comment:
   Not sure if we can remove this. @TaoLv for double check.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to