apeforest commented on a change in pull request #15593: Large Index Support for
Slice
URL: https://github.com/apache/incubator-mxnet/pull/15593#discussion_r311859462
##########
File path: src/c_api/c_api.cc
##########
@@ -537,20 +557,18 @@ int MXNDArrayGetShape(NDArrayHandle handle,
API_END();
}
-int MXNDArrayGetShapeEx(NDArrayHandle handle,
- int *out_dim,
- const int **out_pdata) {
- MXAPIThreadLocalEntry *ret = MXAPIThreadLocalStore::Get();
- API_BEGIN();
- NDArray *arr = static_cast<NDArray*>(handle);
+template<typename dtype>
+inline void GetShape(NDArrayHandle handle, const dtype** out_pdata, int*
out_dim,
Review comment:
Naming should be consistent with `CreateNDArrayImpl`. If @larroy feels
`Impl` is not the best suffix, we can consider `CreateNDArrayHelper` and
`GetShapeHelper`. But all these internal template names sholud have consistent
styles since we may have many of them.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
